Force place_special_forced to place special in forced mode #49778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess this would be a good thing to have in 0.F. |
It did not really affect anything there - the only place where it was used was defense mode (to force place starting locations), but all currently hardcoded location can be placed w/o forcing. |
|
But the "Bordered" challenge was merged from 0.F-dev to 0.F, wasn't it? Or I'm missing something? |
|
"0.F Backport Candidate" are for merging to |
ZhilkinSerg
added a commit
to ZhilkinSerg/Cataclysm-DDA
that referenced
this pull request
Aug 12, 2021
ZhilkinSerg
added a commit
that referenced
this pull request
Aug 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
This should fix #49620, but I can't test it on any compiler other than VS.
Describe the solution
Replaced last argument in
place_special_forcedfromfalsetotrue.Describe alternatives you've considered
None.
Testing
Removed
NDEBUGpreprocessor definition from VS solution.Compiled game on MSVS without these changes, tried to start Bordered scenario, crash.
Compiled game on MSVS with these changes, tried to start Bordered scenario. No crash, game successfully started.
Additional context
None.