Fix CBM install data retrieval when installing CBM on NPC #49759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anothersimulacrum
added
<Bugfix>
ZhilkinSerg
added a commit
to ZhilkinSerg/Cataclysm-DDA
that referenced
this pull request
Aug 12, 2021
ZhilkinSerg
added a commit
that referenced
this pull request
Aug 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fix CBM install data retrieval when installing CBM on NPC"
Purpose of change
Fixes #49752
Describe the solution
Changed code to look for the AID item in the player inventory instead of the patient (target NPC) inventory.
Describe alternatives you've considered
Using regex to parse HTML.
Testing
Before the changes:
Installing a CBM holding both the CBM and install data caused the issue and preventing consuming the AID item (it didn't cause the installation to fail though so it can be considered an exploit). Dropping the AID item to the ground prevented the issue.
After the changes:
Trying to install the CBM when holding the AID item doesn't cause issues anymore and the item is consumed.