Add back legacy wheel definitions #49568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrettDong
added
0.F Backport Candidate
<Bugfix>
|
So it turns out the code is not needed, only the json. |
eltank
changed the title
ZhilkinSerg
added a commit
to ZhilkinSerg/Cataclysm-DDA
that referenced
this pull request
Aug 12, 2021
ZhilkinSerg
added a commit
that referenced
this pull request
Aug 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Add back legacy wheel definitions needed for loading 0.E saves"
Purpose of change
Fixes #49540
Needed for loading 0.E saves in 0.F
Describe the solution
Revert the part of #45765 that deleted legacy wheels.
Describe alternatives you've considered
Digging deeper to find out why vehicles are getting messed up and what's causing the segfaults. That may take a while; this simple fix is useful in the short term.
Testing
Start game, load one of the saves from #49540. Observe functional vehicles.
Additional context
Still don't know why those obsolete wheels are appearing in 0.E saves. The parts should have been upgraded by 0.E migration code.
I would also expect the vehicle code to not fail miserably (and lead to segfaults) when some vehicle parts are invalid. More work is needed there.