Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use normal distribution to generate random height in new character screen #49270

Merged
merged 9 commits into from
Jul 7, 2021
Merged

Use normal distribution to generate random height in new character screen #49270

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d914d28
fix random height
Tairesh Jun 12, 2021
cda8d5e
use Character::randomize_height
Tairesh Jun 12, 2021
57e9b97
use clamp() for limit the randomness, as @pehamm suggested
Tairesh Jun 12, 2021
0fca28f
astyle fix
Tairesh Jun 12, 2021
e26cbef
use std::round instead of round
Tairesh Jun 12, 2021
f1c2e1e
learning c++ in 21 days
Tairesh Jun 13, 2021
702a306
int instead of double
Tairesh Jun 13, 2021
1888d46
use one distribution
Tairesh Jun 14, 2021
f3bbe2d
changed normal_roll to 168.35 mean, 15.5 sd
Tairesh Jun 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/newcharacter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3298,7 +3298,9 @@ tab_direction set_description( avatar &you, const bool allow_reroll,
no_name_entered = you.name.empty();
}
you.set_base_age( rng( 16, 55 ) );
you.set_base_height( rng( 145, 200 ) );
// Height distribution data is taken from this paper:
// http://www.biostat.jhsph.edu/bstcourse/bio751/papers/bimodalHeight.pdf
you.set_base_height( round( you.male ? normal_roll( 176.0, 7.4 ) : normal_roll( 162.8, 7.0 ) ) );
Tairesh marked this conversation as resolved.
Show resolved Hide resolved
you.randomize_blood();
} else if( action == "CHANGE_GENDER" ) {
you.male = !you.male;
Expand Down