Add linux builds to the release workflow #48775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevingranade
changed the title
actual-nh
added
Code: Build
|
Also build is triggered on each merge commit even if previous build was not ever finished. Is it possible to add some waiting time (like on Jenkins), so multiple commits merged in XX minutes were put in a single release? |
|
It looks like that was not possible as of March 2020. See this GitHub community question. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Following up on #48705 , this adds linux curses and tiles builds to the release.
Describe the solution
Interleaved build and dependency steps for the linux targets.
Describe alternatives you've considered
I wasn't happy about how this is starting to duplicate matrix.yml, but I don't see a particularly clean way to have them share their code to any meaningful extent. Something to look into post-release.
Testing
Pushed to my personal repo and built successfully https://github.com/kevingranade/Cataclysm-DDA/releases/tag/experimental-3
Downloaded both linux targets, the artifacts contain what I expect and they run.
Additional context
"Just" need to bolt on mac and android builds now, and maybe tweak the release numbering.