Add LANGUAGES=all to windows experimental release build #48763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actual-nh
added
<Bugfix>
Coolthulhu
referenced
this pull request
in cataclysmbnteam/Cataclysm-BN
Jun 19, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Based on feedback here, this updates the windows experimental release build to include all languages in the artifacts. This is an augment to #48705
Describe the solution
This adds the
LANGUAGES=allflag to the build command.Describe alternatives you've considered
Could leave the flag out, but we probably want all the languages to be included. This change brings this Action closer to the behavior of the jenkins build bot.
Testing
The workflow runs https://github.com/reasonablytall/Cataclysm-DDA/actions/runs/813316453
The artifacts are now the correct size (~60MB) and include the
langfolder.