Flu vaccine expires based on creation time, not start of cataclysm #48742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anothersimulacrum
added
the
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Flu vaccine expires based on creation time, not start of cataclysm"
Purpose of change
It was hardcoded to start to expire counting from the start of cataclysm, but there are methods (Magiclysm, logically also some faction should sell fresh vaccine) to obtain a new one.
Describe the solution
The counter starts at the item's creation, not cataclysm.
QUESTION: Item spawned by mapgen do have their birthday set at the start of cataclysm, right?
Describe alternatives you've considered
None
Testing
Loaded save older than 24 weeks, took an old vaccine, spawned new, took it too. Only latter worked