Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing NO_RELOAD flags #48592

Merged
merged 4 commits into from
Apr 21, 2021
Merged

Conversation

Hirmuolio
Copy link
Contributor

Summary

Bugfixes "Stop unreloadable items from being reloadable"

Purpose of change

There are items that can't be reloaded. You can't get the ammo from anywhere and the item can't be unloaded to get ammo from them.
But these items still showed up in the reload menu.

Items covered:

  • Batteries (vehicle batteries already had the flag)
  • Glowstick and flare
  • Scuba tanks

Describe the solution

Add NO_RELOAD to them so they don't give the reload option anymore.

Describe alternatives you've considered

The active vacuum oven should maybe have this flag too.

Testing

They don't show up in reload menu anymore.

Additional context

@actual-nh actual-nh added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves labels Apr 20, 2021
@actual-nh actual-nh added [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. Info / User Interface Game - player communication, menus, etc. labels Apr 20, 2021
@ZhilkinSerg ZhilkinSerg merged commit 207a94d into CleverRaven:master Apr 21, 2021
Salty-Panda pushed a commit to Salty-Panda/Cataclysm-DDA that referenced this pull request May 3, 2021
Salty-Panda pushed a commit to Salty-Panda/Cataclysm-DDA that referenced this pull request May 3, 2021
@Hirmuolio Hirmuolio deleted the batteries branch July 31, 2021 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. Info / User Interface Game - player communication, menus, etc. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants