Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] New Spell: Nature's Commune #48330

Merged
merged 5 commits into from
Jul 12, 2021

Conversation

Termineitor244
Copy link
Contributor

@Termineitor244 Termineitor244 commented Apr 2, 2021

Summary

Mods "Adds a new druidic spell giving the effects of Animal Empathy and a little health"

Purpose of change

Druids are all about their relation with nature, but they currently don't have any means to be in peace with that same nature (fauna), so why don't give them a spell with that effect?

Describe the solution

A new druidic spell "Nature's Commune", that makes you enter a magical state of communion with the nature around you, calming the natural animals and making you a little healthier, since you are "embraced" by the mother nature, the health effect is mainly of real (immediate) health, so given enough time without another commune, your body will tend towards its old, unhealthy state.

Describe alternatives you've considered

Two different spells, or a healing/stamina regeneration effect.

Testing

Made the json changes, tested, they give the health in the proportions I want, I then compiled the game, and the effect in wildlife works as it should, a bunch of rabbits stay in my vicinity if I'm under the effect of the spell, and run away the moment the spell duration ends.

Additional context

This was originally a regeneration buff spell, but I discarded that idea and ended with this (in my opinion) better and needed alternative.

This is a draft because I still have to add the spell to books that seem appropriate, but if anyone wants to make changes to the spell itself, I'm open to suggestions.

Edit: Added the spell to the basic druidic book, to a new scroll, and to the Ecoterrorist profession (seems appropriate).

@Termineitor244 Termineitor244 requested a review from KorGgenT as a code owner April 2, 2021 21:27
@Termineitor244 Termineitor244 marked this pull request as draft April 2, 2021 21:28
@BrettDong BrettDong added Mods: Magiclysm Anything to do with the Magiclysm mod [JSON] Changes (can be) made in JSON labels Apr 2, 2021
Copy link
Contributor

@actual-nh actual-nh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! (@BrettDong: Unfortunately needs a String Freeze label.)

data/mods/Magiclysm/Spells/druid.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/effects/effects.json Outdated Show resolved Hide resolved
data/mods/Magiclysm/items/spell_scrolls.json Outdated Show resolved Hide resolved
@Termineitor244 Termineitor244 marked this pull request as ready for review April 2, 2021 22:42
@Termineitor244
Copy link
Contributor Author

Termineitor244 commented Apr 2, 2021

@actual-nh Thanks for the help with the grammar and syntax!

@KorGgenT
Copy link
Member

ran out of time to check this PR this morning. what i need to check before i can make a determination on the balance (or maybe you can tell me) is how much total hp you regenerate in the duration of the spell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Mods: Magiclysm Anything to do with the Magiclysm mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants