Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect iOS system language #48104

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Conversation

BrettDong
Copy link
Member

Summary

None

Purpose of change

The iOS counterpart of #47977: to really detect system language.

Describe the solution

This is much easier than #47977 because macOS and iOS share the same API for retrieving system language. Just re-use the existing macOS codepath.

Testing

Tested on iPhone: game language follows system language unless the user manually overrides in game settings.

Additional context

System language is set to French:
IMG_2517
Game language is now in French:
IMG_2515

@BrettDong BrettDong added Translation I18n [C++] Changes (can be) made in C++. Previously named `Code` labels Mar 17, 2021
@actual-nh
Copy link
Contributor

Side note: "Bugs" and "Suggestions" are the same in (Canadian) French as English? Interesting.

@BrettDong
Copy link
Member Author

Yes it's spelled in the same way in French.

@ZhilkinSerg ZhilkinSerg merged commit 9f303de into CleverRaven:master Mar 18, 2021
@BrettDong BrettDong deleted the ios-lang branch March 19, 2021 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Translation I18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants