Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix disassembly component display #47869

Conversation

Jamuro-g
Copy link
Contributor

@Jamuro-g Jamuro-g commented Mar 4, 2021

Summary

Interface "Fix disassembly component display"

Purpose of change

The disassembly ui didn't stack components used in the fabrication of items (only looted items had their components stacked due to that being the way they are formated in the recipe)

Fixes #38028

Describe the solution

Iterate over found components and stack them neatly

Testing

  • Spawn in cargo pants
  • Spawn in the components needed to make cargo pants ( use short string due to them being item stacks not charges)
  • Craft the cargo pants
  • Enter disassembly view and compare
  • Previously: the strings would show up as 3 stacks of 2
  • Now: they are a single stack

How it looks:
image

@anothersimulacrum anothersimulacrum added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. labels Mar 4, 2021
@Rivet-the-Zombie Rivet-the-Zombie merged commit 5960368 into CleverRaven:master Mar 5, 2021
VuradoZ referenced this pull request in VuradoZ/Cataclysm-BN Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crafted item components dont seem stacked in disassemble window
3 participants