added status msg to oil splatter knockdown

[Jamuro-g]

Summary

Bugfixes "Added status msg to oil splatter field knockdown"

Purpose of change

Slipping on mechanical fluid fields gave the same status msg to the player as any other knockdown, potentially causing confusion.

Resolves #47847

Describe the solution

Made the knockdown effect of oil fields it's own effect and changed the status message sent to the player

Testing

• Spawn in a crow II and shoot it
• Move over the spawned mechanical splatter fields until you get knocked down

[Fris0uman]

You need to format your json change https://github.com/CleverRaven/Cataclysm-DDA/blob/master/doc/JSON_STYLE.md
You can use this tool http://dev.narc.ro/cataclysm/format.html by just copy pasting stuf in it.

Did you check that this downed_oil effect actually does something other than just displaying the message?

[Qrox]

Did you check that this downed_oil effect actually does something other than just displaying the message?

In addition to that, this also introduces the doubtful situation where you can be "knocked to the floor" by monster attack when you are already on the ground after slipping.

I suggest just changing the downed effect message to something more general like "you drop to the ground" and print an additional message when slipping on oil.

[jagoly]

Why not just print an extra message before applying the effect?

"You slip on the mechanical fluid!"
"You're knocked to floor!"

I'd argue this sounds perfectly reasonable. It reads as a cause, then an effect, like the other common causes for getting knocked to the floor (monster hits your torso, etc).

[Fris0uman]

Hardcoding one more message is not great though.

[Jamuro-g]

oh wow this got more attention than i thought ... it wasn't exactly ready (was just a bit slow on hitting the draft button)

anyways ... if we don't want to use a sepperate effect for this then i can just add the message, no problem.

In addition to that, this also introduces the doubtful situation where you can be "knocked to the floor" by monster attack when you are already on the ground after slipping.

This shouldn't happen, the downed_oil effect is added to the dragdown check.

[Jamuro-g]

oil splatter no longer causes a downed effect, obsoleting this pr (closed)