Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more nutrition debug #47716

Merged
merged 6 commits into from
Mar 18, 2021
Merged

Conversation

RadHazard
Copy link
Contributor

@RadHazard RadHazard commented Feb 24, 2021

Summary

None

Purpose of change

As part of debugging my fix for #47663, I needed a good way to check/edit NPC stomach contents and the faction camp larder. This adds debug tools for both things. I'm adding these tools as a separate PR from that (pending) fix due to the string freeze.

Describe the solution

Added stomach contents to the needs menu, and also a function to edit faction camp calories

Describe alternatives you've considered

It was suggested I could add this with untranslated strings to make it into 0.F, but I figured since this is a debug menu feature it's not critical to have in 0.F

Testing

Ate something, verified that the displayed stomach contents changed as expected. Removed stomach contents and verified that the contents are correctly gone. Edited the faction camp larder and verified that the # menu shows the new value.

Additional context

image

@anothersimulacrum anothersimulacrum added 0.F String Freeze [C++] Changes (can be) made in C++. Previously named `Code` labels Feb 24, 2021
@anothersimulacrum
Copy link
Member

We should have a broader discussion about whether or not we translate debugging tools/messages - I'm not sure they really need to be translated.

@actual-nh
Copy link
Contributor

actual-nh commented Feb 24, 2021

We should have a broader discussion about whether or not we translate debugging tools/messages - I'm not sure they really need to be translated.

From TRANSLATING.md:

Error and debug messages must not be marked for translation.
When they appear, the player is expected to report them *exactly* as they are
printed by the game.

Debugging (and error) messages are not included in String Freeze - only translated messages are. (I asked about this in #42658.) I believe this includes anything going into debug.log, or emitted during tests; it does not include debug menu items and responses to them, as in this case, probably at least partially because a user may be instructed to use one of them in order to fix a problem with their game.

@anothersimulacrum
Copy link
Member

Debugging (and error) messages are not included in String Freeze - only translated messages are. (I asked about this in #42658.) I believe this includes anything going into debug.log, or emitted during tests; it does not include debug menu items and responses to them, as in this case, probably at least partially because a user may be instructed to use one of them in order to fix a problem with their game.

In that case, this should not be translating the strings it is introducing.

@RadHazard
Copy link
Contributor Author

In that case, this should not be translating the strings it is introducing.

Are you sure? It seems like actual-nh was saying that debug log message should not be translated, but debug menu items should. This adds new debug menu items, so would fall under the latter category.

Incidentally, the current debug menu is almost if not entirely translated, and that's the example I followed.

@actual-nh
Copy link
Contributor

In that case, this should not be translating the strings it is introducing.

Are you sure? It seems like actual-nh was saying that debug log message should not be translated, but debug menu items should. This adds new debug menu items, so would fall under the latter category.

That is my interpretation. @BrettDong, any comments?

Incidentally, the current debug menu is almost if not entirely translated, and that's the example I followed.

@BrettDong
Copy link
Member

Debug messages shown in the sidebar are generally not translated, while debug menu interface shown as pop-up windows displayed in the center of the screen are generally translated.

@anothersimulacrum
Copy link
Member

Ah my bad, I totally misread what you said (and then I quoted it!).

@ZhilkinSerg ZhilkinSerg changed the base branch from master to 0.F-dev March 18, 2021 20:29
@ZhilkinSerg ZhilkinSerg merged commit 0402dc9 into CleverRaven:0.F-dev Mar 18, 2021
@ZhilkinSerg ZhilkinSerg mentioned this pull request Mar 18, 2021
14 tasks
ZhilkinSerg pushed a commit that referenced this pull request Mar 18, 2021
* add stomach and gut kCal to the debug menu

* Add detailed stomach and gut data to the needs menu

* add debug command to edit the faction camp larder

* Add debug command to empty a character's stomach & guts

* Add stored & total kCal view to the info box
ZhilkinSerg pushed a commit that referenced this pull request Mar 21, 2021
* add stomach and gut kCal to the debug menu

* Add detailed stomach and gut data to the needs menu

* add debug command to edit the faction camp larder

* Add debug command to empty a character's stomach & guts

* Add stored & total kCal view to the info box
ZhilkinSerg pushed a commit that referenced this pull request Mar 21, 2021
* add stomach and gut kCal to the debug menu

* Add detailed stomach and gut data to the needs menu

* add debug command to edit the faction camp larder

* Add debug command to empty a character's stomach & guts

* Add stored & total kCal view to the info box
John-Candlebury pushed a commit to John-Candlebury/Cataclysm-DDA that referenced this pull request Mar 24, 2021
* add stomach and gut kCal to the debug menu

* Add detailed stomach and gut data to the needs menu

* add debug command to edit the faction camp larder

* Add debug command to empty a character's stomach & guts

* Add stored & total kCal view to the info box
ZhilkinSerg pushed a commit that referenced this pull request Mar 25, 2021
* add stomach and gut kCal to the debug menu

* Add detailed stomach and gut data to the needs menu

* add debug command to edit the faction camp larder

* Add debug command to empty a character's stomach & guts

* Add stored & total kCal view to the info box
ZhilkinSerg pushed a commit that referenced this pull request Mar 25, 2021
* add stomach and gut kCal to the debug menu

* Add detailed stomach and gut data to the needs menu

* add debug command to edit the faction camp larder

* Add debug command to empty a character's stomach & guts

* Add stored & total kCal view to the info box
ZhilkinSerg pushed a commit that referenced this pull request Mar 25, 2021
* add stomach and gut kCal to the debug menu

* Add detailed stomach and gut data to the needs menu

* add debug command to edit the faction camp larder

* Add debug command to empty a character's stomach & guts

* Add stored & total kCal view to the info box
ZhilkinSerg pushed a commit that referenced this pull request Mar 26, 2021
* add stomach and gut kCal to the debug menu

* Add detailed stomach and gut data to the needs menu

* add debug command to edit the faction camp larder

* Add debug command to empty a character's stomach & guts

* Add stored & total kCal view to the info box
ZhilkinSerg pushed a commit that referenced this pull request Mar 31, 2021
* add stomach and gut kCal to the debug menu

* Add detailed stomach and gut data to the needs menu

* add debug command to edit the faction camp larder

* Add debug command to empty a character's stomach & guts

* Add stored & total kCal view to the info box
ZhilkinSerg pushed a commit that referenced this pull request Mar 31, 2021
* add stomach and gut kCal to the debug menu

* Add detailed stomach and gut data to the needs menu

* add debug command to edit the faction camp larder

* Add debug command to empty a character's stomach & guts

* Add stored & total kCal view to the info box
ZhilkinSerg pushed a commit that referenced this pull request Mar 31, 2021
* add stomach and gut kCal to the debug menu

* Add detailed stomach and gut data to the needs menu

* add debug command to edit the faction camp larder

* Add debug command to empty a character's stomach & guts

* Add stored & total kCal view to the info box
BrettDong pushed a commit that referenced this pull request Apr 5, 2021
* add stomach and gut kCal to the debug menu

* Add detailed stomach and gut data to the needs menu

* add debug command to edit the faction camp larder

* Add debug command to empty a character's stomach & guts

* Add stored & total kCal view to the info box
ZhilkinSerg pushed a commit that referenced this pull request Apr 7, 2021
* add stomach and gut kCal to the debug menu

* Add detailed stomach and gut data to the needs menu

* add debug command to edit the faction camp larder

* Add debug command to empty a character's stomach & guts

* Add stored & total kCal view to the info box
ZhilkinSerg pushed a commit that referenced this pull request Apr 9, 2021
* add stomach and gut kCal to the debug menu

* Add detailed stomach and gut data to the needs menu

* add debug command to edit the faction camp larder

* Add debug command to empty a character's stomach & guts

* Add stored & total kCal view to the info box
ZhilkinSerg pushed a commit that referenced this pull request Apr 20, 2021
* add stomach and gut kCal to the debug menu

* Add detailed stomach and gut data to the needs menu

* add debug command to edit the faction camp larder

* Add debug command to empty a character's stomach & guts

* Add stored & total kCal view to the info box
ZhilkinSerg pushed a commit that referenced this pull request Apr 20, 2021
* add stomach and gut kCal to the debug menu

* Add detailed stomach and gut data to the needs menu

* add debug command to edit the faction camp larder

* Add debug command to empty a character's stomach & guts

* Add stored & total kCal view to the info box
ZhilkinSerg pushed a commit that referenced this pull request Apr 20, 2021
* add stomach and gut kCal to the debug menu

* Add detailed stomach and gut data to the needs menu

* add debug command to edit the faction camp larder

* Add debug command to empty a character's stomach & guts

* Add stored & total kCal view to the info box
ZhilkinSerg pushed a commit that referenced this pull request May 28, 2021
* add stomach and gut kCal to the debug menu

* Add detailed stomach and gut data to the needs menu

* add debug command to edit the faction camp larder

* Add debug command to empty a character's stomach & guts

* Add stored & total kCal view to the info box
ZhilkinSerg pushed a commit that referenced this pull request May 28, 2021
* add stomach and gut kCal to the debug menu

* Add detailed stomach and gut data to the needs menu

* add debug command to edit the faction camp larder

* Add debug command to empty a character's stomach & guts

* Add stored & total kCal view to the info box
ZhilkinSerg pushed a commit that referenced this pull request May 31, 2021
* add stomach and gut kCal to the debug menu

* Add detailed stomach and gut data to the needs menu

* add debug command to edit the faction camp larder

* Add debug command to empty a character's stomach & guts

* Add stored & total kCal view to the info box
ZhilkinSerg pushed a commit that referenced this pull request Jun 14, 2021
* add stomach and gut kCal to the debug menu

* Add detailed stomach and gut data to the needs menu

* add debug command to edit the faction camp larder

* Add debug command to empty a character's stomach & guts

* Add stored & total kCal view to the info box
ZhilkinSerg pushed a commit that referenced this pull request Jun 14, 2021
* add stomach and gut kCal to the debug menu

* Add detailed stomach and gut data to the needs menu

* add debug command to edit the faction camp larder

* Add debug command to empty a character's stomach & guts

* Add stored & total kCal view to the info box
ZhilkinSerg pushed a commit that referenced this pull request Jun 14, 2021
* add stomach and gut kCal to the debug menu

* Add detailed stomach and gut data to the needs menu

* add debug command to edit the faction camp larder

* Add debug command to empty a character's stomach & guts

* Add stored & total kCal view to the info box
ZhilkinSerg pushed a commit that referenced this pull request Jun 21, 2021
* add stomach and gut kCal to the debug menu

* Add detailed stomach and gut data to the needs menu

* add debug command to edit the faction camp larder

* Add debug command to empty a character's stomach & guts

* Add stored & total kCal view to the info box
ZhilkinSerg pushed a commit that referenced this pull request Jul 3, 2021
* add stomach and gut kCal to the debug menu

* Add detailed stomach and gut data to the needs menu

* add debug command to edit the faction camp larder

* Add debug command to empty a character's stomach & guts

* Add stored & total kCal view to the info box
anothersimulacrum pushed a commit to anothersimulacrum/Cataclysm-DDA that referenced this pull request Jul 3, 2021
* add stomach and gut kCal to the debug menu

* Add detailed stomach and gut data to the needs menu

* add debug command to edit the faction camp larder

* Add debug command to empty a character's stomach & guts

* Add stored & total kCal view to the info box
KorGgenT pushed a commit to KorGgenT/Cataclysm-DDA that referenced this pull request Jul 4, 2021
* add stomach and gut kCal to the debug menu

* Add detailed stomach and gut data to the needs menu

* add debug command to edit the faction camp larder

* Add debug command to empty a character's stomach & guts

* Add stored & total kCal view to the info box
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants