-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manual labour doesn't make you sleepy #47512
Conversation
removed mod_fatigue(), mod_stored_nutr(), mod_thirst() calls from various activities
This pull request introduces 1 alert when merging f1b6443 into 1e40b42 - view on LGTM.com new alerts:
|
Co-authored-by: actual-nh <[email protected]>
what should I do about this test failing?
|
Sigh... it isn't your doing; some of the fields tests have some randomness involved (whether something spreads to another tile, in this case), so they fail (probably more often than they should, but that's a matter for another PR - check out Aivean's comments in #46256 for a bit more background and #47218 for a couple thoughts on this). |
Looks good to me with or without the trog adjustment, just need a quick test to verify that these activities are still suitably exhausting after the adjustment. |
decreases the pain a troglobite takes when mining with a pickaxe Co-authored-by: actual-nh <[email protected]>
Looks like "CR" can be removed. @kevingranade: What is your definition of "adequately fatiguing"? I can get some exact data by running weary-type tests on the various activities in question (looking at things like stamina, fatigue, and morale as well as weariness via debug_weary_info). |
hey, this actually merged! thanks a lot for your help @actual-nh, i appreciate it a lot!! |
Summary
Bugfixes "removed mod_fatigue(), mod_stored_nutr(), mod_thirst() calls from various activities"
Purpose of change
Fixes #47391
Describe the solution
by removing the functions calls, manual labour doesn't make you sleepy anymore