Fix powered tools not consuming charges on use #47485
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fix powered tools not consuming charges on use"
Purpose of change
This PR makes the following changes:
charges_per_use
tool property rather thanmax_charges
. This is necessary to evade unwanted side effects like magazine spawning and barter price reduction, an also to have tools withoutmax_charges
consume charges. This fixes Electric Firestarter Not Consuming Battery Charges #40269Testing
To check for power tools not consuming charges, spawn an electric firestarter, reload it and use it to light a fire. If the bug is there, you'll see that its charges remain the same.