Fix game freeze when player cannot contain mission reward #47287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fix game freeze when player cannot contain mission reward"
Purpose of change
Fix #47282 : The game stuck in an infinite loop trying to add the mission reward item to the player's inventory when the player cannot contain it.
Describe the solution
Swap the order of two statements in
item_pocket::handle_liquid_or_spill
.Describe alternatives you've considered
A band-aid fix, see BrettDong@29e4c2b: Add a check
can_stash
. If the player cannot stash the reward item, then place it on the ground instead. This avoids the infinite loop.Testing
Load the save in #47282 and the game does not freeze.