Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zombie technician pull metal weapon attack tweak #47066

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Zombie technician pull metal weapon attack tweak #47066

merged 1 commit into from
Jan 29, 2021

Conversation

Night-Pryanik
Copy link
Contributor

Summary

SUMMARY: Bugfixes "Zombie technician pull metal weapon attack tweak."

Purpose of change

This reddit post showed that technician's attack might lead to weird consequences, like pulled active grenade not exploding until technician is dead.

Describe the solution

Replaced adding pulled weapon to monster inventory with pulling it to monster location.
Also slightly reworded the text ("katana is pulled from your hands" -> "The katana is pulled from your hands").

Describe alternatives you've considered

None.

Testing

Debug-spawned zombie technician, wield a katana, waited for technician to trigger its attack. Observed my katana is removed from my hands and placed to technician's location.

Additional context

In the future we might need to replace magic teleporting of pulled thing with actual pulling, which might lead to harming anyone standing in the way.

… monster location

Also slightly reworded the text ("katana is pulled from your hands" -> "The katana is pulled from your hands").
@Night-Pryanik Night-Pryanik added Game: Mechanics Change Code that changes how major features work [C++] Changes (can be) made in C++. Previously named `Code` Monsters Monsters both friendly and unfriendly. labels Jan 27, 2021
@Rivet-the-Zombie Rivet-the-Zombie merged commit 0ec6948 into CleverRaven:master Jan 29, 2021
@Night-Pryanik Night-Pryanik deleted the pull_metal_weapon_tweak branch January 29, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Game: Mechanics Change Code that changes how major features work Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants