Add bunch of unit tests for fields #47061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add new unit tests for fields
BrettDong
added
the
Fields / Furniture / Terrain / Traps
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Increasing unit test coverage for the fields in preparation for #47032.
Describe the solution
Add bunch of unit tests for various field aspects.
Also, discovered and fixed bug in
fd_flame_burstintensity (implementation expected 3 levels of intensity, while only one level was defined in json).Testing
Ran tests from
[fields]category 10+ times, hope there won't be any new flakiness introduced.