added check for parent in insertion menu (no more bagception)

[Jamuro-g]

Summary

SUMMARY: Bugfixes "added a check for parent items in the insertion menu"

Purpose of change

A check that compares the holsters parent to the item is added to prevent storing the bag that contains the bag that is trying to store the bag ... bagception prevented

Fixes #46904

Describe the solution

The items in the insert ui are compared to the holsters parent to prevent players from trying to store a bag inside itself via a proxi bag.

Describe alternatives you've considered

Leaving it in and creating a black hole spell effect that instantly murders the player and everything on the screen?

Testing

Spawn 2 bagpacks
Wear backpack 1
Insert backpack 2 in it
Open the insert menu for backpack 2 (not inside backpack 1) and look for backpack 1

[moxian]

I have a feeling there might be other ways to create bagception (now or in the future)..
Since you've worked through the code already, would it be possible/easy to also add a debugmsg when the bagception actually occurs? ("This is out of scope of this PR" would be a valid answer though)

[Jamuro-g]

I have a feeling there might be other ways to create bagception (now or in the future)..
Since you've worked through the code already, would it be possible/easy to also add a debugmsg when the bagception actually occurs? ("This is out of scope of this PR" would be a valid answer though)

I took a quick glance and made a note for later, but i don't think i am familiar enough with the code yet to confidently make changes in visitable.cpp
From what i ve seen the best/only locations to implement such a check would be in item::put_in() but at that point we are already inside items that are unaware of their item_locations.
What's left is to adjust visitables, which i think is basically handling pretty much any and all item navigaion.