Fix trap's trigger_weight being ignored if less than 500g #46872
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fix trap's trigger_weight being ignored if less than 500g"
Purpose of change
The code block for triggering a trap by item is only entered when item weight is greater than 500 grams. Hence
trigger_weight
JSON field is not respected when its value is less than 500 grams, e.g. bear traps whosetrigger_weight
is 200 grams.Fix #41538.
Describe the solution
Move the code block out from the branch whose condition is item weight greater than 500 grams.
Describe alternatives you've considered
None yet.
Testing
However, in
master
branch version, throwing a cellphone (270 grams) does not trigger the bear trap, which disobeystrigger_weight
of bear traps.