Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Reverses subtraction in character.cpp to correct skill rust calculation" #46831

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Revert "Reverses subtraction in character.cpp to correct skill rust calculation" #46831

merged 1 commit into from
Jan 22, 2021

Conversation

Foxtrot-Uniform42
Copy link
Contributor

@Foxtrot-Uniform42 Foxtrot-Uniform42 commented Jan 17, 2021

Summary

SUMMARY: Bugfixes "Corrects skill rust calculation based on intelligence stat. Revert #46605"

Purpose of change

In 'new' rust system #37281 higher 'skill rust' value leads to lower skill rust calculation in game (e.g. skill rust 200% is better than 50%).

Describe the solution

Set intelligence back to increase skill rust value to 'Higher intelligence = slower skill rusts' behavior.

Describe alternatives you've considered

Please refer to #46789

Testing

  • Skill rust 10%
  • All skills set to 30
  • Lost 12% after 24 hours
    LowSkillRust_START1
  • Skill rust 180%
  • All skills set to 30
  • Lost 1% after 24 hours
    HighSkillRust_START!

@BrettDong
Copy link
Member

It would be better if you write more specifically what bug you are addressing in the summary line, because that will be compiled into a change log.

@BrettDong BrettDong added <Bugfix> This is a fix for a bug (or closes open issue) Mechanics: Character / Player Character / Player mechanics [C++] Changes (can be) made in C++. Previously named `Code` labels Jan 17, 2021
@Zireael07
Copy link
Contributor

Out of scope for this PR, but this means the display in character creation should make it clear that bigger % is better.

@Foxtrot-Uniform42
Copy link
Contributor Author

Out of scope for this PR, but this means the display in character creation should make it clear that bigger % is better.

I'll make another PR to change skill rust naming

@ToxiClay
Copy link
Contributor

Sorry about this, folks. I went forward with my PR assuming that the text was accurate.

@Foxtrot-Uniform42
Copy link
Contributor Author

Sorry about this, folks. I went forward with my PR assuming that the text was accurate.

I should've tested skill rust behavior before creating issue in a first place anyway, so...

@ToxiClay
Copy link
Contributor

Out of scope for this PR, but this means the display in character creation should make it clear that bigger % is better.

I'll make another PR to change skill rust naming

The next PR should also address variable naming. rust_rate() is part of what led me to my assumption regarding the underlying math.

@kevingranade kevingranade merged commit 8a5a5d1 into CleverRaven:master Jan 22, 2021
@Foxtrot-Uniform42 Foxtrot-Uniform42 deleted the revert-46605-skill-rust-inversion branch January 22, 2021 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Mechanics: Character / Player Character / Player mechanics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants