Expand weary (debugging) info #46757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expand debug_weary_info (in character.cpp) to give enough information to reconstruct reasons for weary_threshold variations. (cherry picked from commit e559d90)
Realized that weariness being above 0 at the start could cause the level fluctuations. (cherry picked from commit 686c1f3)
Intermittent errors in weary tests (see CleverRaven#46256) are hard to debug without more information. While this information has been expanded in CleverRaven#46473, this does not give enough examples, nor is it able to tell what in "normal" builds is causing intermittent weary test problems.
BrettDong
added
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Expand weary-related debugging info"
Purpose of change
Intermittent errors in weary tests (see #46256) are hard to debug without more information. While this information has been expanded in #46473, this does not give enough examples, nor is it able to tell what in "normal" builds is causing intermittent weary test problems.
Describe the solution
debug_weary_infogives more information, including statistics used to determineweary_threshold, and is called more places during testing. During activity tests, weariness level change tracking now also tracks the actual weariness level andweary_threshold.Describe alternatives you've considered
Altering the Github and/or Travis matrices used in #46473 so that they go on independently even if another compiler/etc combination fails, to increase the amount of debugging information available from that PR alone. The solution in this PR is preferable, since it will increase the amount of information available without monopolizing testing resources.
Testing
See #46473; these modifications have been in use in that PR.