Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prone move mode #46750
Prone move mode #46750
Changes from 32 commits
1a5c01b
7ca6a4a
51393c8
fd41d6e
a48274d
7a04ee8
50d6fdc
52dc27a
e693355
d5fb976
1a58a46
1020898
471409f
4483773
02119f2
7671474
f832851
e148aae
b33be5e
6af0ae9
50bc506
e59d533
583e81c
019b9a6
d6a5b12
f99eb17
69e7fd9
cc55bc7
76d2579
1e35df7
039765b
21f8f35
b7bc3ef
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the player wake up, do they need to manually switch back to walking?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Laying down to sleep is a conscious effort. Waking up is not. As such i think switching back to walking should be manual
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are other actions that require conscious effort but is done automatically anyway, for example assignment of containers to inventory items. Not automatically switching back to walking might confuse players (especially those updating from an earlier version and are used to waking up in walking mode).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not hung up on it so I can add that, no problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A warning message would be nice here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's pain mentioned in message, maybe then actually add some pain on this event?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot other places where
effect_downed
is used. Should these places be updated as well?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed earlier. There is a huge variety of reasons
effect_downed
is used. I don't think this is in this PR scope to identify and change themThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will the player fall over when trying to attack with their crutches?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not really thought of that. Should he fall over but still deal damage or just fall over and that's it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can make it depend on melee skill, or maybe we can just display a message that says you can't attack with crutches when your legs are broken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added check when performing melee if legs are broken. Currently you just cannot melee attack while you have broken legs. I don't think melee skill should affect that. But that's just a balance issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe in the future we should allow fighting (defending only?) while lying down, if your arms ain't broken.