-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Aftershock] Design Doc Draft #46666
[Aftershock] Design Doc Draft #46666
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting! I am looking forward to further developments (and helping with a few).
Co-authored-by: actual-nh <[email protected]>
Let me take a look at this, but one thing that stands out to me is the "here be dragons" section Do we need this? It just identifies where files go, and a quick "git grep" or asking maintainers could figure out where everything goes I think? |
That's a question you can ask, it will cause me to ask questions about your parentage and how you are exceptionally polite for someone raised by wolves, who doesn't believe in Table of Contents. I am a firm believer in tables of contents and that as a mod grows in size they become even more important as eventually we may need to use those ToC spaces to explain design choices and request additional content from contributors. :) |
It is also a bit out of date - item groups are under, well, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good for the first draft!
I'll be keeping an eye on this, and if anything stands out I'll make sure to note a review of it!
Hahaha completely fair, I was mostly asking as there wasn't a table of contents in regular dda, or any other mod from what I know, so I was curious, but that makes sense considering how big this mod will end up being; so I'm alright with keeping it. |
Co-authored-by: actual-nh <[email protected]>
Oh another important thing, have you included something specifying how aftershock isn't a dumping mod? |
I haven't for a couple of reasons.
Anyway I'm totes fine with someone else writing up some kind of dump mod disavowal bur I'm not gonna worry about it in this PR. |
Ah those reasons make sense, yeah! Alright, this draft looks good by me then, as it mentions everything important so far :) |
Just FYI, once this is where you want it, we could put it on cataclysmdda.org for higher visibility. |
Just to note, if the other maintainers don't object to it of course, I would love to have it on the site yea. |
Co-authored-by: actual-nh <[email protected]>
Co-authored-by: actual-nh <[email protected]>
Co-authored-by: actual-nh <[email protected]>
Co-authored-by: actual-nh <[email protected]>
Co-authored-by: actual-nh <[email protected]>
Co-authored-by: John Candlebury <[email protected]>
Will there eventually be a version of aftershock that includes just more sci-fi stuff without the full conversion? for people who do want sci-fi but not a whole conversion. |
In-repo, no. You can always copy and paste the sci-fi stuff yourself and put it into a mod without the conversion stuff however. |
Summary
SUMMARY: Mods "Aftershock Design Doc"
Purpose of change
Update design doc to reference the ongoing total conversion mod direction that Aftershock is taking.
Describe the solution
Updates Readme.MD. First draft. Putting some words to paper. Open to suggestions. @Mom-Bun
Describe alternatives you've considered
None
Testing
N/A
Additional context