Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent examine on the creature you're mounted on #46627

Merged
merged 1 commit into from
Jan 8, 2021

Conversation

Saicchi
Copy link
Contributor

@Saicchi Saicchi commented Jan 8, 2021

Summary

SUMMARY: None

Purpose of change

A small oversight from my PR in #46600 let the friendly examine menu appear on the pet you're mounted on.
Fortunately there are no big bugs in there and the game can handle stuff correctly.

Describe the solution

Add check to see if the player is mounted before opening menu.

Describe alternatives you've considered

None

Testing

No longer brings the menu up for the pet while mounting it, working like it was before #46600

Additional context

None

Copy link
Member

@BrettDong BrettDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested: no menu appears if player examines the tile that is currently on while riding a horse.

@anothersimulacrum anothersimulacrum added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` labels Jan 8, 2021
@actual-nh
Copy link
Contributor

There are no other purposes for which a character might examine the tile they're on?

@Saicchi
Copy link
Contributor Author

Saicchi commented Jan 8, 2021

I'm just disabling the new menu if the player is mounted so it is like it was before. You can't really interact with anything while mounted, nor pick up items.

@ZhilkinSerg ZhilkinSerg merged commit 2b301cd into CleverRaven:master Jan 8, 2021
@Saicchi Saicchi deleted the examinefix branch January 8, 2021 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants