Close #46439 (segmentation error) #46498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a patch suggested by @anothersimulacrum, prevents a segmentation error (instead giving a much more useful failed test).
BrettDong
added
[C++]
BrettDong
approved these changes
Jan 2, 2021
There was a problem hiding this comment.
Confirmed that following reproducing instructions in #46441 (comment), cata_test segfaults in master version, and fails without crashing in this PR:
../tests/vehicle_ramp_test.cpp:276: FAILED:
REQUIRE( dmon_p )
with expansion:
nullptr
===============================================================================
test cases: 8 | 5 passed | 3 failed
assertions: 2959 | 2956 passed | 3 failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Close #46539: Segmentation error in vehicle_level_test"
Purpose of change
Close #46439: Avoid a segmentation error (and hard-to-reconstruct failure) during the vehicle_level_test. (This still fails under the same circumstances, but without a segmentation error.)
Describe the solution
As suggested/found by @anothersimulacrum, do a check for whether dmon_p is null (in this case, due to the player being where the test wanted to create a debug monster).
Describe alternatives you've considered
Well, fixing the bug causing the failure would be nice, but is rather difficult with dealing with segmentation faults & stack corruption (?) problems...
Testing
See #46473.
Additional context
See #46476 for @anothersimulacrum's suggestion, and #46441 for some further analysis of the test failure.