Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show presence of monsters when examining #46432

Merged
merged 1 commit into from
Jan 1, 2021

Conversation

wapcaplet
Copy link
Contributor

@wapcaplet wapcaplet commented Dec 31, 2020

Summary

SUMMARY: Interface "Show presence of monsters when examining"

Purpose of change

When using e to examine an adjacent tile, the existence of monsters (hostile, friendly, or neutral) was not indicated in any way. Thus, when using e on a tile containing a zombie, dog, cow, moose or any other animal, the message log would only say "That is a grass" or "That is a pavement."

Describe the solution

Change e to print "There is a zombie" or "There is a cow" for example, when such a creature is in the examined space. Also refactor the surrounding section slightly.

Describe alternatives you've considered

This could be embellished to suggest taming for tameable monsters, or to danger-highlight hostile monsters, but those could be successive PRs.

Testing

Spawn monsters, and examine them. See their existence mentioned in the message log.

Additional context

After:
image

When using `e` to examine an adjacent tile, the existence of monsters
(hostile, friendly, or neutral) was not indicated in any way.

Change `e` to print "There is a zombie" or "There is a cow" for example,
when such a creature is in the examined space.
@wapcaplet wapcaplet added [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. Monsters Monsters both friendly and unfriendly. labels Dec 31, 2020
Copy link
Member

@BrettDong BrettDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it's working as described. Branches to pet menu, etc. is unaffected and works normally.

@ZhilkinSerg ZhilkinSerg merged commit 32b33c4 into CleverRaven:master Jan 1, 2021
@wapcaplet wapcaplet deleted the w-there-be-monsters branch March 1, 2021 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants