Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in scenario selection menu #46393

Merged
merged 1 commit into from
Dec 31, 2020
Merged

Conversation

ZhilkinSerg
Copy link
Contributor

Summary

SUMMARY: None

Purpose of change

Fixes #46392

@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) labels Dec 29, 2020
@actual-nh
Copy link
Contributor

For applicable OSes, is SIGWINCH being dealt with (might be internally in the SDL/ncurses libraries)?

src/newcharacter.cpp Outdated Show resolved Hide resolved
src/newcharacter.cpp Outdated Show resolved Hide resolved
@ZhilkinSerg ZhilkinSerg force-pushed the fix-ui-crash-2020-12-29 branch from 89f9bc8 to b419692 Compare December 29, 2020 20:43
@ZhilkinSerg ZhilkinSerg added the (P2 - High) High priority (for ex. important bugfixes) label Dec 29, 2020
@ZhilkinSerg
Copy link
Contributor Author

For applicable OSes, is SIGWINCH being dealt with (might be internally in the SDL/ncurses libraries)?

#37894

@kevingranade kevingranade merged commit ad21647 into master Dec 31, 2020
@kevingranade kevingranade deleted the fix-ui-crash-2020-12-29 branch December 31, 2020 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` (P2 - High) High priority (for ex. important bugfixes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash in scenario selection menu on smaller terminal height
3 participants