Show source location in error messages of deferred json #46350
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Show source location in error messages of deferred json objects"
Purpose of change
Source location did not show correctly for deferred json objects. This PR fixes it.
Describe the solution
JsonObject
string, so the deferred json can be loaded using the actual path and display the correct source location.lru_cache
to load data files of deferred json so loading performance does not degrade.Testing
Tested on top of #46337.
Before, without json errors
Before, with json errors
Error message example
After, without json errors
After, with json errors
Error message example