XL clothing adjustments #46299
Merged
XL clothing adjustments #46299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anothersimulacrum
added
[JSON]
ghost
marked this pull request as ready for review
BrettDong
reviewed
Jan 8, 2021
Co-authored-by: Binrui Dong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: NonePurpose of change
There are some issues with XL gear.
-Having 4 substitutions for XL(huge/oversized/gigantic/extra large) makes searching a hassle, along with different words for some like chestrig/chitin/without fingers vs. chest rig/chitinous/fingerless.
-Some recipes have shorter crafting times than normal sized.
-Some tool qualities & components are missing from the recipes.
Describe the solution
-Change the substitutions to all XL.
-Lengthened the crafting times to be longer than the normal-sized if missing.
-Add back the required qualities & components.
Describe alternatives you've considered
Keeping the XL substitutions.
Testing
Read every recipe to check for longer time, identical proficiencies & tool qualities. Read every XL gear for consistent spelling so you can search either XL to find all oversized gear or the base item to see if there's an XL variant.
Additional context