Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow completing monster killing mission by killing the fusing monster when the mission target is fused #46295

Merged
merged 4 commits into from
Dec 30, 2020

Conversation

Qrox
Copy link
Contributor

@Qrox Qrox commented Dec 24, 2020

Summary

SUMMARY: Bugfixes "Allow completing monster killing mission by killing the fusing monster when the mission target is fused"

Purpose of change

Fixes #46283.

Describe the solution

  1. Fix a premature return caused by the death_drops flag, so mission status is correctly updated when a monster dies when death_drops is false.
  2. When a monster you are asked to kill gets fused with another monster, you'll have to kill the fusing monster to complete the mission. However, if you are asked to find the monster, the mission counts as failed instead.
  3. When a mission monster is fused into another monster, a message will be displayed hinting that the fusing monster needs to be killed. The fusing monster's description will mention the fused monster and the name will start with an asterisk so the player can more easily spot the monster.

Describe alternatives you've considered

Go easy on the player and count fused monster as killed.
Make a mission specific flag that counts fused monster as killed.

Testing

Added the kill zombie mom mission to an NPC via the debug menu, teleported to the zombie mom, spawned a dissoluted devourer, and waited until it fuses with the zombie mom. The mission still required killing the devourer. Bashed the devourer to death, and the mission was then updated.

@anothersimulacrum anothersimulacrum added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Missions Quests and missions Monsters Monsters both friendly and unfriendly. labels Dec 24, 2020
@Qrox Qrox marked this pull request as draft December 26, 2020 13:30
@Qrox Qrox marked this pull request as ready for review December 26, 2020 13:48
src/map.cpp Outdated Show resolved Hide resolved
@kevingranade kevingranade merged commit 33a39df into CleverRaven:master Dec 30, 2020
@Qrox Qrox deleted the fused branch December 30, 2020 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Missions Quests and missions Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dissoluted devourer breaks mission
3 participants