Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infrastructure "Only run workflow actions for relevant changes" #46272

Merged
merged 14 commits into from
Dec 27, 2020

Conversation

int-ua
Copy link
Contributor

@int-ua int-ua commented Dec 23, 2020

Summary

SUMMARY: None

Purpose of change

Do not run complete builds unnecessarily.

Describe the solution

Used on.<push|pull_request>.paths in GitHub workflows and skip_commits in appveyor.yml to try ignoring changes.

Describe alternatives you've considered

I'd like to use inclusion list instead of exclusion on the general build matrix but I need help with defining it.

Testing

By GitHub infrastructure.

Additional context

https://discord.com/channels/598523535169945603/598529174302490644/791280543496273941

@int-ua int-ua changed the title [CR] Ignore docs/, tools/ and lgtm/ changes in build matrix [CR] Only run workflow actions for relevant changes Dec 23, 2020
this might not work as expected
@int-ua int-ua marked this pull request as ready for review December 23, 2020 12:40
@anothersimulacrum anothersimulacrum added the Code: Tests Measurement, self-control, statistics, balancing. label Dec 23, 2020
@int-ua int-ua changed the title [CR] Only run workflow actions for relevant changes [CR] Only run GitHub workflow actions for relevant changes Dec 23, 2020
@int-ua int-ua changed the title [CR] Only run GitHub workflow actions for relevant changes [CR] Only run workflow actions for relevant changes Dec 23, 2020
@int-ua int-ua changed the title [CR] Only run workflow actions for relevant changes Only run workflow actions for relevant changes Dec 24, 2020
@int-ua int-ua requested a review from ZhilkinSerg December 24, 2020 16:43
@ZhilkinSerg
Copy link
Contributor

In order to make Github actions run faster we should probably decrease fetch depth too and do a shallow clone with depth of 1 instead of 10.

@ZhilkinSerg ZhilkinSerg merged commit a05173d into CleverRaven:master Dec 27, 2020
@int-ua int-ua deleted the patch-4 branch December 27, 2020 17:46
@int-ua
Copy link
Contributor Author

int-ua commented Dec 27, 2020

Didn't notice that, thank you. Reduced in #46361

@int-ua
Copy link
Contributor Author

int-ua commented Dec 27, 2020

Looks like @appveyor thinks that if build was skipped by the skip_commits: directive it's a failure 😠

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code: Tests Measurement, self-control, statistics, balancing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants