Audit .223 STANAG magazines, add max_item_length to ammo pouches #46251
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Balance "Audit .223 STANAG magazines, add max_item_length to ammo pouches"
Purpose of change
Weights were very random
Volumes were illogical (Stanag 20 was heavier and bigger than Stanag 30)
Magazines had no max length.
Secondary: Dedicated ammo containers don't have a max_item_length set. Pockets are limited by MAG_COMPACT, but the game defaults them to small max_item_length.
Describe the solution
Audited based on real-world information where I could find them and estimations where I couldn't
Add max_item_length to ammo pouches
Set max_item_length of AMMO_COMPACT pouches to 24cm, MAG_BULKY ones to 30cm.
Describe alternatives you've considered
Do nothing
Testing
Put Stanag 30 (19cm) into various ammo pouches that accept MAG_COMPACT and have a limit of 24cm.
Failed to put Stanag 100 (35cm) into those pouches.
Failed to put Stanag 50 drum into those pouches.
Put Stanag 50 drum into tac vest, which accepts MAG_BULKY
Additional context
Detailed spreadsheet, source links, estimations marked
https://docs.google.com/spreadsheets/d/1foxk7S1diwP7s4NVytM_bDT-L7ymwDXIxicEA4Ti1vI/edit?usp=sharing