-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comprehensive grammar sweep #46181
Comprehensive grammar sweep #46181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definite improvements!
Co-authored-by: Jianxiang Wang (王健翔) <[email protected]>
Co-authored-by: actual-nh <[email protected]>
Co-authored-by: actual-nh <[email protected]>
Co-authored-by: actual-nh <[email protected]>
Wouldn't want someone trying to use a military ID card to open a science lab Co-authored-by: actual-nh <[email protected]>
Co-authored-by: actual-nh <[email protected]>
Co-authored-by: actual-nh <[email protected]>
Co-authored-by: actual-nh <[email protected]>
Co-authored-by: actual-nh <[email protected]>
Style guides don't seem to agree on whether to follow i.e. with a comma. Co-authored-by: actual-nh <[email protected]>
Co-authored-by: actual-nh <[email protected]>
Co-authored-by: actual-nh <[email protected]>
Co-authored-by: actual-nh <[email protected]>
Co-authored-by: actual-nh <[email protected]>
Co-authored-by: actual-nh <[email protected]>
Co-authored-by: actual-nh <[email protected]>
Co-authored-by: actual-nh <[email protected]>
Co-authored-by: actual-nh <[email protected]>
Co-authored-by: actual-nh <[email protected]>
Co-authored-by: actual-nh <[email protected]>
Co-authored-by: actual-nh <[email protected]>
Co-authored-by: actual-nh <[email protected]>
All proposed changes reviewed and incorporated, to one extent or another. Lingering issue: in most cases, the Help screen uses a dynamic replacement for buttons, like
I couldn't find where the codebase sets out what the |
See data/raw/keybindings.json#L1040. Looks like <press_aim>, <press_aimed_shot>, <press_careful_shot>, and <press_precise_shot> should work, although this will require testing. |
Co-authored-by: actual-nh <[email protected]>
It seems not...fortunately, I can test JSON edits without needing to build CDDA from source.
|
Hrm. Ah. I think I see where I went wrong. It looks like only ones in action.cpp's action_ident or look_up_action work... which doesn't include any of these at the moment. Change in a future PR, perhaps. |
Co-authored-by: actual-nh <[email protected]>
Co-authored-by: actual-nh <[email protected]>
Co-authored-by: Serhiy Zahoriya <[email protected]>
Summary
SUMMARY: None
Purpose of change
The purpose of this change is to correct, standardize, and prettify the
texts.json
file that controls what is displayed in the game's Help menu.Describe the solution
I sat down and went over the file.
Describe alternatives you've considered
None.
Testing
Attempting to lint the file resulted in a syntax error alert. Impact unknown.
Additional context