Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use id for movement mode tile overlays #45940

Merged

Conversation

satheon49
Copy link
Contributor

@satheon49 satheon49 commented Dec 9, 2020

Summary

SUMMARY: Bugfixes "Tileset should not use translated strings for movement mode overlay ids"

Purpose of change

Fixes #45935

If movement modes were translated for a language, for example spanish overlay_female_run became overlay_female_correr

Describe the solution

Use movement mode ids instead of translated strings.

Describe alternatives you've considered

Testing

  1. Set tileset to UltiCa
  2. Open character and change movement mode to run
  3. Notice overlay icon in lower left corner
  4. Change language to Espanol (Argentina)
  5. Overlay icon is still there

Additional context

@satheon49 satheon49 changed the title #45935 use id for movement mode tile overlays use id for movement mode tile overlays Dec 9, 2020
@anothersimulacrum anothersimulacrum added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` SDL: Tiles / Sound Tiles visual interface and sounds. labels Dec 9, 2020
@ZhilkinSerg ZhilkinSerg merged commit f357db6 into CleverRaven:master Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` SDL: Tiles / Sound Tiles visual interface and sounds.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running indicator is not displayed.
4 participants