Add Baseball Player profession #45937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It might need some re-balancing
anothersimulacrum
added
[JSON]
|
If I were you, I'd change the PR title to be more descriptive - e.g. "Add Baseball Player profession". This repo has A LOT of PR open at the same time and this helps the devs review them. |
hjk321
suggested changes
Dec 9, 2020
|
No love for P.S. Bookmark our linter so the formatting issues don't happen in future PRs. |
|
Co-authored-by: Hiram Anderson <[email protected]>
Co-authored-by: Hiram Anderson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "Add Baseball Player profession"
Purpose of change
Currently, there isn't any profession that starts with the baseball gear.
Testing
I started a new game and chose "Baseball Player" as a profession. Checked inventory and skills.
1.Start a new game.
2.Select a scenario where you can choose all the professions.
3.Choose the "Baseball Player" profession and create the character.
Additional context
The profession in the profession selecting menu
Skills check
Inventory check
