Trivial: speedup npc::get_monster_faction #45423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aivean
added
[C++]
This was referenced Aug 22, 2023
scarf005
added a commit
to scarf005/Cataclysm-BN
that referenced
this pull request
Aug 22, 2023
ports CleverRaven/Cataclysm-DDA#45423 Co-authored-by: Aivean <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Performance "speedup npc::get_monster_faction"
Purpose of change
Currently
npc::get_monster_factionconstructsstring_idfrom raw string each time it's called.This is an unnecessary waste of CPU time.
Describe the solution
Change
faction_template::mon_factiontype fromstd::stringtomfaction_str_id. This avoids on-demandstring_idcreation and saves some memory.Describe alternatives you've considered
None.
Testing
Checked that game compiles and loads.
Additional context
Note: profiled on top of #45376 for full effect (generic factory caches
is_validlookups).Before:
After:
