Fixes inaccurate wait durations in the "Wait a while" menu #45418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anothersimulacrum
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fixes inaccurate wait duration in the Wait a while menu"
Purpose of change
The actual time waited for each of the entries in the Wait a while menu was 1 second shorter than it should have been. This applied to both relative (5 minutes) and absolute (until noon) waits. The issue was brought in over 4 years ago in #17116 and I don't really see why? Maybe the initial turn the activity was created wasn't counted back then.
Fixes #45352
Describe the solution
Remove
- 1from wait code.Describe alternatives you've considered
It's impossible to unsee. There is no alternative.
Testing