AIM liquid transfer fix #45298
Merged
AIM liquid transfer fix #45298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anothersimulacrum
added
<Bugfix>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "AIM liquid transfer endless liquid fix"
Purpose of change
Fixes #45287
Describe the solution
Deducts the amount of content used from the source container and unseals it.
Describe alternatives you've considered
Wait for PR #45243 as it will overwrite all this code eventually anyway.
Testing
Full test program ran with no errors.
Transfer of liquids using AIM. Sealed water bottles, 60L barrel, 2.5L canteen, condom, and gallon jug all tested between each other.
Additional context
Issue found while testing: Encumbrance is not updated when source of water is in a non-rigid container in inventory. This is after flagging the container, pocket, and avatar to update encumbrance.
This also happens when unloading from a non-rigid container in inventory - not using the AIM screen. Problem is likely related to Issue #42983.