Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DinoMod] Implements rideable zombie T Rex via missions #45273

Merged
merged 29 commits into from
Jun 14, 2021
Merged

[DinoMod] Implements rideable zombie T Rex via missions #45273

merged 29 commits into from
Jun 14, 2021

Conversation

LyleSY
Copy link
Contributor

@LyleSY LyleSY commented Nov 6, 2020

Summary

SUMMARY: Mods "Implements rideable zombie T Rex via missions"

Purpose of change

Weave together DinoMod content into a clearer progression for the player, add interest and diversity, new mid/late game goal

Describe the solution

Two new rideable zombie dinos. Two new Old Guard missions to offer them.

Describe alternatives you've considered

New content in the shelter computer, but doesn't appear to be moddable. Dino rescue mission for swampers, couldn't get working, not sure if it's possible

Testing

Worldgen works, game can start, and Red NPC spawns and offers first mission. In the last test Betty spawned after completing mission 3 and immediately started eating the Old Guard. Set aggression to 0 to fix.

Additional context

Shout out to Mutaman for the T Rex support

@mlangsdorf mlangsdorf added <Enhancement / Feature> New features, or enhancements on existing Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) NPC / Factions NPCs, AI, Speech, Factions, Ownership labels Nov 7, 2020
@LyleSY LyleSY changed the title [DinoMod] more missions [WIP] [DinoMod] more missions Nov 7, 2020
@LyleSY LyleSY added the [JSON] Changes (can be) made in JSON label Nov 7, 2020
@LyleSY
Copy link
Contributor Author

LyleSY commented Nov 26, 2020

Travis pit digging weariness test is not related

@LyleSY
Copy link
Contributor Author

LyleSY commented Dec 5, 2020

I'm still getting circular dependency errors at load, need to strip more back to find the issue

@stale
Copy link

stale bot commented Jan 14, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Jan 14, 2021
@stale stale bot removed the stale Closed for lack of activity, but still valid. label Feb 2, 2021
@LyleSY LyleSY changed the title [WIP] [DinoMod] more missions [WIP] [DinoMod] Implements rideable zombie T Rex via missions Feb 3, 2021
@LyleSY LyleSY added the <Bugfix> This is a fix for a bug (or closes open issue) label Feb 3, 2021
@LyleSY LyleSY removed the <Bugfix> This is a fix for a bug (or closes open issue) label Feb 10, 2021
@LyleSY
Copy link
Contributor Author

LyleSY commented Feb 10, 2021

Stripping out bugfix content for a separate PR

@LyleSY
Copy link
Contributor Author

LyleSY commented Mar 7, 2021

Sigh, reward dinos eat the NPCs. Needs some more work

@LyleSY LyleSY changed the title [WIP] [DinoMod] Implements rideable zombie T Rex via missions [DinoMod] Implements rideable zombie T Rex via missions Apr 4, 2021
@LyleSY LyleSY marked this pull request as ready for review April 4, 2021 17:10
@actual-nh
Copy link
Contributor

actual-nh commented Apr 4, 2021

Sigh, reward dinos eat the NPCs. Needs some more work

There are a few choices:

  • Move the reward dinos to a new monster faction (base_faction their original monster faction) that's NEUTRAL or FRIENDLY to the human monster faction. This does mean they'll never attack any human.
  • Move the reward dinos to a new monster faction that's FRIENDLY to "player", if the NPCs are in the player faction.
  • Move the reward dinos to a new monster faction that's FRIENDLY to "player" and to a new monster faction (base_faction human) that the mon_faction entry on the NPCs' faction points to.
  • Drop the aggression, but note that anything raising their aggression sufficiently will still result in attacking anything they have BY_MOOD toward (such as humans by default).

EDIT: Note that if they don't have anything raising their aggression from 0, they'll never attack anything. Is this desirable?

@ZhilkinSerg
Copy link
Contributor

Sigh, reward dinos eat the NPCs.

Seems to be working as intended.

@Maleclypse Maleclypse changed the base branch from master to 0.F-dev June 9, 2021 02:07
@Maleclypse
Copy link
Member

@LyleSY would this be ready for merge to the dev branch? Or are you still working on the monster faction stuff to keep them from eating NPCs?

@LyleSY
Copy link
Contributor Author

LyleSY commented Jun 9, 2021

Yes, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants