Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly implement translator comments check for the _() macro #45250

Merged
merged 1 commit into from
Nov 5, 2020
Merged

Properly implement translator comments check for the _() macro #45250

merged 1 commit into from
Nov 5, 2020

Conversation

Qrox
Copy link
Contributor

@Qrox Qrox commented Nov 5, 2020

Summary

SUMMARY: None

Purpose of change

Follow up on #45217. Properly detect the _() macro instead of working it around by adding another marker.

Describe the solution

  1. Detect the _() macro along with translate_marker etc.
  2. Update the clang-tidy test.

Testing

Ran the clang-tidy test and it passed.

@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` Code: Build Issues regarding different builds and build environments Code: Tests Measurement, self-control, statistics, balancing. Translation I18n labels Nov 5, 2020
@ZhilkinSerg ZhilkinSerg merged commit 146d314 into CleverRaven:master Nov 5, 2020
@Qrox Qrox deleted the translator-comments-check branch December 12, 2020 06:44
@olanti-p olanti-p mentioned this pull request Jan 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Build Issues regarding different builds and build environments Code: Tests Measurement, self-control, statistics, balancing. Translation I18n
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Qrox @ZhilkinSerg