Allow insect regeneration #45241
Merged
Allow insect regeneration #45241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlangsdorf
added
<Enhancement / Feature>
kevingranade
reviewed
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Insects currently can't naturally regenerate HP, since that code only checks for the material types "flesh" or "veggy". This PR adds "iflesh" as an accepted material too.
Alternatives
Changing the material of insects to flesh, and adding the JSON flag "Arthropod blood" one-by-one, keeping this all JSON.
Testing
Compiled, spawned a cow, a triffid and a centipede in closed rooms of a LMOE Shelter. Whacked them with a stick till they got down to red health, teleported away and waited a day. After teleporting back they all were back to full health.
Additional context
The regen rate seems a bit overtuned, with one day allowing a triffid queen to get back to full health, but changing that is definitely a bigger balance consideration than what I wanted to start with.
This is my first time successfully messing with C++, so tell me if I'm touching something I'm not supposed to and I can do the messy JSON fix instead.