Remove posible infinite loop in place_roads #44968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/crash-when-reading-road-trail-ect-maps/24899/13 |
mlangsdorf
added
<Bugfix>
This was referenced Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Remove possible infinite loop in place_roads"
Purpose of change
This should fix #44736
Describe the solution
Rework the way the random out of the overmap road connections are chosen in a way that removes the posibility of infinite loops. Might be better ways to evaluate the points than with a rather large shuffled array. I wouldnt know them however.
Testing
Make a world with Aftershock enabled and teleport across lake overmaps several times, experience no crashes.
At least that was my experience.
Additional context
There can be other mapgen related hangups when lakes get ever larger, I tried lake sizes 0.01 to 0.05 and all caused hangups. Aftershock's size of 0.12 seems safe with this change, at the least.