#44459 make disabling a monster an activity with variable duration #44670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Autoquark
force-pushed
the
issue_44459
branch
4 times, most recently
from
f65dee6 to
7e98071
Compare
Autoquark
force-pushed
the
issue_44459
branch
2 times, most recently
from
f246390 to
34e89f3
Compare
Autoquark
force-pushed
the
issue_44459
branch
from
34e89f3 to
e7d49e9
Compare
Autoquark
changed the title
anothersimulacrum
added
<Bugfix>
BrettDong
reviewed
Jan 1, 2021
|
@Autoquark are you still working on this? |
|
Hi, I had this ready to merge for a while but no one hit the button so it's become out of date. I could fix the conflicts but I don't know what the chances of it actually getting merged are? |
|
As far as I know, the only barrier to this being merged is it having conflicts and the mergers reviewing it. |
Co-authored-by: Binrui Dong <[email protected]>
|
Cleared some merge conflicts, need to review carefully that I didn't break something. |
kevingranade
reviewed
Jul 8, 2021
|
Yep I mangled the merge dangit. Working on a fix now. |
anothersimulacrum
pushed a commit
to anothersimulacrum/Cataclysm-DDA
that referenced
this pull request
Jul 18, 2021
…duration (CleverRaven#44670) * CleverRaven#44459 disabling a robot is an activity with variable duration Co-authored-by: Binrui Dong <[email protected]> Co-authored-by: Kevin Granade <[email protected]>
pjf
added a commit
to pjf/Cataclysm-DDA
that referenced
this pull request
Jul 19, 2021
* origin/master: Rebalance bionic, fix some weird stats (CleverRaven#46212) CleverRaven#44459 make disabling a monster an activity with variable duration (CleverRaven#44670)
|
Did you test if Hub01s Iron Safari mission is still completable with this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Balance "Disabling is now an activity that takes variable time depending on TODO"
Purpose of change
Fixes #44459
Describe the solution
Adds a new activity, ACT_DISABLE, for disabling/reprogramming a robot. Activity is disabled if the bot becomes an invalid target (e.g. hostile bot recovers from stunning) or if it moves. To prevent friendly bots from moving, added a new status worked_on which is applied during the activity and prevents them from moving.
The time to disable a robot in moves is (2000 / (electronics + mechanics)).
Describe alternatives you've considered
Testing
Tested disabling both a nursebot and disabling/reprogramming a manhack (manhacks have special reprogramming options). Tested with a friendly bot and a stunned bot, verifying that the activity is interrupted on a stunned bot when it recovers and that a friendly bot does not move during the activity.
Additional context
Consultation Request: I need suggestions for how the time for the disable activity should be calculated. Any comments on the implementation are also welcome.
Edit: I have gone with the above formula for now, suggestions from more experienced players are still welcome.