Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some conflicting profession clothes, add MD trait where appropriate #44622

Merged
merged 4 commits into from
Oct 7, 2020

Conversation

Fallout48
Copy link
Contributor

Summary

SUMMARY: Bugfixes "Fixes some conflicting profession clothes, adds the MD trait where appropriate"

Purpose of change

Fixes #44619

Also gives the MD trait to some more medical professions where they would probably have the experience.

Describe the solution

Removes the gendered underwear from the Speed King/Queen, since they already have compression clothes.
Removes their motorcycle armor as it conflicts with the leather touring suit.

Adds the MD trait to the EMT, Paramedic, and Combat Medic.
(I didn't add it to them initially, because the description of MD seems to imply they've just got out of med school. Which is a little odd for the more experienced medical professions but that's just my two cents.)

Describe alternatives you've considered

Going nude all together.
Performing first aid without a medical license.

Testing

No errors from what I can see?

Additional context

It's silly that the stethoscope conflicts with bags and backpacks.

Removed the Speed King's gendered underwear (since they have compression clothes), and motorcycle armor. 
Added MD trait to EMT, Paramedic, and Combat Medic since the other medical professions have it.
//The MD trait kinda implies you're straight out of med school, despite being on professions where you have a lot of medical experience. Feels a bit odd but that's just my two cents.
@Termineitor244
Copy link
Contributor

Great! I was wondering about the MD trait too but I did not include in the issue because I don´t remember what it does.

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies labels Oct 7, 2020
@ZhilkinSerg ZhilkinSerg merged commit 3586ad4 into CleverRaven:master Oct 7, 2020
@Fallout48 Fallout48 deleted the patch-1 branch October 8, 2020 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Speed King/Queen (And others) profession's clothing is a mess
3 participants