Don't call item::put_in on full brass catcher #44601
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Fixes #44151
The brass catcher would overflow and print a message when it did so.
Describe the solution
Check if the brass catcher had room for a casing before attempting to insert it.
Describe alternatives you've considered
A more invasive fix was attempted in #44155, but at the end of the day I don't like the approach of silencing the check if the caller claims to handle it instead of insisting that the caller should always insure that the insertion will succeed.
Testing
Spawned a gun, attacked a brass catcher, fired it until the brass catcher filled up and started dropping casings on the ground.