Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extends the new Satiety row to more information menus #44565

Merged
merged 13 commits into from
Oct 7, 2020
Merged

Extends the new Satiety row to more information menus #44565

merged 13 commits into from
Oct 7, 2020

Conversation

gkarfakis19
Copy link
Contributor

@gkarfakis19 gkarfakis19 commented Oct 2, 2020

Summary

SUMMARY: Interface "Extends the new Satiety row to more item information menus"

Purpose of change

Fixes (partially) #44560.
The useful Satiety row should be added to more menus, and not just to the (E)at menu.

Describe the solution

Currently adds the satiety bar to the inventory and crafting item information screen

Describe alternatives you've considered

Not adding this.

Testing

Inventory menu:
image

Crafting menu:
image

Additional context

@gkarfakis19 gkarfakis19 marked this pull request as draft October 2, 2020 15:55
The old compute_calories_per_effective volume now gets an optional parameter that lets it accept an external nutrient (kcal) value, and as such, it works with the crafting menus calorie ranges min_cal - max_cal.
@gkarfakis19 gkarfakis19 changed the title [CR] Extends the new Satiety row to more information boxes [CR] Extends the new Satiety row to more information menus Oct 3, 2020
@gkarfakis19 gkarfakis19 marked this pull request as ready for review October 4, 2020 11:34
@gkarfakis19 gkarfakis19 changed the title [CR] Extends the new Satiety row to more information menus Extends the new Satiety row to more information menus Oct 7, 2020
Ready to merge.
@ZhilkinSerg ZhilkinSerg merged commit 71a3d2f into CleverRaven:master Oct 7, 2020
@anothersimulacrum anothersimulacrum added [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. labels Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants