simplify item::damage_level()

[Hirmuolio]

Summary

SUMMARY: Infrastructure "simplify item::damage_level()"

Purpose of change

item::damage_level( int max ) had max value of 4 in every single place where it was used. The max value does not need to exist.

Describe the solution

Find and replace damage_level( 4 ) -> damage_level()
Replace the max value in the equations with 4.
Update definitions.

Describe alternatives you've considered

Let it be.

Testing

Compiles, test pass.
Item damage levels still showthe same.

Additional context

Maybe it should have return damage_ > 0 ? 4 : -1; instead of return damage_ > 0 ? 4 : damage_; to match how its behavior with negative item damage is described in item.h. But I decided not to change its behavior at all and I don't think there is any place where code cares about it.

[kevingranade]

I think @ZhilkinSerg had some plans for this in the future, namely expanding field intensity levels once his overhaul has progressed far enough.

[ZhilkinSerg]

I think @ZhilkinSerg had some plans for this in the future, namely expanding field intensity levels once his overhaul has progressed far enough.

Item damage level (capped at 4) is a different thing from field intensity levels (capped at 3).

[kevingranade]

Whoops, I was elbow-deep in field code when I read this so I got confused.

…

On Sun, Oct 4, 2020, 1:25 AM ZhilkinSerg ***@***.***> wrote: I think @ZhilkinSerg <https://github.com/ZhilkinSerg> had some plans for this in the future, namely expanding field intensity levels once his overhaul has progressed far enough. Item damage level (capped at 4) is a different thing from field intensity levels (capped at 3). — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#44563 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGSA5BW2RYPULP7K3BUUFLSJAWP3ANCNFSM4SB3BTVQ> .