Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the description of Strict Humanitarian to make it more compatible with the Cannibal trait. #44344

Merged
merged 3 commits into from
Sep 23, 2020

Conversation

gkarfakis19
Copy link
Contributor

@gkarfakis19 gkarfakis19 commented Sep 22, 2020

Summary

SUMMARY: Interface "Changed the description of Strict Humanitarian to clarify its effects."

Purpose of change

Fixes #44318. Instead of making cannibal incompatible with Strict Humanitarian, changing Strict Humanitarian's flavour text from: "You'd never eat people, but these things that look vaguely human from elsewhere are definitely not people" to: "Your culinary definitions were always quite relaxed. You no longer receive a mood malus from eating otherwordly humanoids." is an easier fix, which also clarifies the trait's nebulous effects.

EDIT: New description changed to "You're convinced that these things that look vaguely human from elsewhere are definitely not people. Therefore it's okay to eat them, right?". Credit to Fris0uman.

Describe the solution

Simple JSON edit.

Describe alternatives you've considered

Completely renaming Strict Humanitarian and making it a prerequisite/lower form of Cannibal, since it's not really that useful a trait anyway.

Testing

Additional context

@gkarfakis19 gkarfakis19 changed the title [CR] [WIP] Changed the description of Strict Humanitarian to make it more compatible with the Cannibal trait. [CR] Changed the description of Strict Humanitarian to make it more compatible with the Cannibal trait. Sep 22, 2020
@anothersimulacrum anothersimulacrum added [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies labels Sep 22, 2020
@gkarfakis19 gkarfakis19 changed the title [CR] Changed the description of Strict Humanitarian to make it more compatible with the Cannibal trait. Changed the description of Strict Humanitarian to make it more compatible with the Cannibal trait. Sep 22, 2020
@cosmo-naut
Copy link
Contributor

Does the name 'Strict Humanitarian' even make sense?

Co-authored-by: Jianxiang Wang (王健翔) <[email protected]>
@Rivet-the-Zombie Rivet-the-Zombie merged commit f550509 into CleverRaven:master Sep 23, 2020
@gkarfakis19 gkarfakis19 deleted the TempBranch1 branch October 4, 2020 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strict Humanitarian should conflict with Cannibal
6 participants