Fix unit test terminating message not starting on new line #44257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anothersimulacrum
added
the
Code: Tests
jbytheway
reviewed
Sep 20, 2020
| printf( "\nTreating result as failure due to error logged during tests.\n" ); | ||
| printf( "Randomness seeded to: %u\n", seed ); | ||
| DebugLog( D_INFO, DC_ALL ) << "Treating result as failure due to error logged during tests."; |
There was a problem hiding this comment.
It was convenient to have the seed printed out here too since its at the end of the output and easy to find.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
If an exception is thrown during test initialization before any other debug message is printed, the terminating message does not start on its own line.
Describe the solution
Use
DebugLoginstead ofprintfso messages always starts on their own line. Furthermore, print the exception message on its own line too so it can be captured by github problem matcher. Removed(?:Terminated: )?in the regexp of problem matcher since it's no longer needed.Also, removed two lines of redundant code outputing the rand seed of unit test. The seed is already printed at the beginning of the test, and the removed lines did not check for zero value which means not seeding the random engines explicitly.
Testing
Ran the unit test and the terminating message is now on its own line.